Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #231 #267 blog post data packages relevant to the pharmaverse #263

Merged

Conversation

bms63
Copy link
Collaborator

@bms63 bms63 commented Dec 14, 2024

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Ensure your new post folder is of the form "posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge into main.
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@bms63 bms63 linked an issue Dec 14, 2024 that may be closed by this pull request
@bms63

This comment was marked as resolved.

@manciniedoardo

This comment was marked as resolved.

@khatril

This comment was marked as resolved.

@bms63

This comment was marked as resolved.

@bms63
Copy link
Collaborator Author

bms63 commented Feb 14, 2025

I will fix the actions, but @manciniedoardo and @StefanThoma this could be reviewed and published today/monday??

@StefanThoma
Copy link
Collaborator

am taking a look right now

Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful post!
What is missing for me is a bit of context and guidance:

  1. Which datasets are consistent / compatible across? I.e. could come from the same study?
  2. Why are there these different datasets around, how do they differ, and who uses them?
  3. Which should I use?

There is already some of that in here, specifically for the random.cdisc.data, but I'd be curious to know more.

manciniedoardo

This comment was marked as resolved.

@bms63
Copy link
Collaborator Author

bms63 commented Feb 14, 2025

useful post! What is missing for me is a bit of context and guidance:

  1. Which datasets are consistent / compatible across? I.e. could come from the same study?

pharmaversesdtm and SafetyData are ports of CDISC pilot data

  1. Why are there these different datasets around, how do they differ, and who uses them?

I don't really know that history that well. I just wanted to gather information on them and have them all in one place for someone who wants to explore CDISC more or wants more data to tests things out (say a new package)

  1. Which should I use?

There is already some of that in here, specifically for the random.cdisc.data, but I'd be curious to know more.

I'm reluctant to write an advice section.

Thanks @manciniedoardo and @StefanThoma for very helpful review (definitely a shoot from the hip blog). I want to keep this post as simple as possible. I do plan on updating it with additional sources as they come in - in fact I am hoping this blog shakes the bushes a little as this can not be all the publicly available data out there

@bms63
Copy link
Collaborator Author

bms63 commented Feb 14, 2025

@StefanThoma and @manciniedoardo I fixed the link checker GHA action - the AI gods gave me a quick assist.

Ready for final review on Monday

@bms63 bms63 linked an issue Feb 14, 2025 that may be closed by this pull request
@bms63 bms63 changed the title Closes #231 blog post data packages relevant to the pharmaverse Closes #231 #267 blog post data packages relevant to the pharmaverse Feb 14, 2025
Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor suggestions

@bms63
Copy link
Collaborator Author

bms63 commented Feb 17, 2025

Very minor suggestions

Thanks @StefanThoma updated!!

@manciniedoardo publish this post?

@manciniedoardo
Copy link
Collaborator

manciniedoardo commented Feb 17, 2025

Very minor suggestions

Thanks @StefanThoma updated!!

@manciniedoardo publish this post?

sure - i'll just try update the post dates workflow before we merge as it's not quite running as expected

@manciniedoardo manciniedoardo self-requested a review February 17, 2025 13:57
Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben!

PS: if publishing doesn't work I'll revert the update to the workflows to ensure your post is published today.

@manciniedoardo manciniedoardo merged commit 7550af7 into main Feb 17, 2025
4 of 5 checks passed
@manciniedoardo manciniedoardo deleted the 231-blog-post-data-packages-relevant-to-the-pharmaverse branch February 17, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Link checker not working properly Blog Post: Data packages relevant to the pharmaverse
4 participants