-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #231 #267 blog post data packages relevant to the pharmaverse #263
Closes #231 #267 blog post data packages relevant to the pharmaverse #263
Conversation
…ckages-relevant-to-the-pharmaverse
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…ckages-relevant-to-the-pharmaverse
I will fix the actions, but @manciniedoardo and @StefanThoma this could be reviewed and published today/monday?? |
am taking a look right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useful post!
What is missing for me is a bit of context and guidance:
- Which datasets are consistent / compatible across? I.e. could come from the same study?
- Why are there these different datasets around, how do they differ, and who uses them?
- Which should I use?
There is already some of that in here, specifically for the random.cdisc.data, but I'd be curious to know more.
Co-authored-by: Edoardo Mancini <[email protected]>
Co-authored-by: Edoardo Mancini <[email protected]>
Co-authored-by: Edoardo Mancini <[email protected]>
Co-authored-by: Edoardo Mancini <[email protected]>
Co-authored-by: Edoardo Mancini <[email protected]>
Co-authored-by: Edoardo Mancini <[email protected]>
Co-authored-by: Edoardo Mancini <[email protected]>
Co-authored-by: Edoardo Mancini <[email protected]>
pharmaversesdtm and SafetyData are ports of CDISC pilot data
I don't really know that history that well. I just wanted to gather information on them and have them all in one place for someone who wants to explore CDISC more or wants more data to tests things out (say a new package)
I'm reluctant to write an advice section. Thanks @manciniedoardo and @StefanThoma for very helpful review (definitely a shoot from the hip blog). I want to keep this post as simple as possible. I do plan on updating it with additional sources as they come in - in fact I am hoping this blog shakes the bushes a little as this can not be all the publicly available data out there |
@StefanThoma and @manciniedoardo I fixed the link checker GHA action - the AI gods gave me a quick assist. Ready for final review on Monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor suggestions
Co-authored-by: StefanThoma <[email protected]>
Co-authored-by: StefanThoma <[email protected]>
Thanks @StefanThoma updated!! @manciniedoardo publish this post? |
sure - i'll just try update the post dates workflow before we merge as it's not quite running as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ben!
PS: if publishing doesn't work I'll revert the update to the workflows to ensure your post is published today.
Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task."posts/zzz_DO_NOT_EDIT_<your post title>"
. This is so that the post date can be auto-updated upon the merge intomain
.CICD.R
line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!tag(s)
or categories from the current list:c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical")
for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up alltags
for consistency.description
field at the top of the markdown document.This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)